Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Whitelist the SPH star_formation_rate field #4446

Merged
merged 1 commit into from
May 15, 2023
Merged

Whitelist the SPH star_formation_rate field #4446

merged 1 commit into from
May 15, 2023

Conversation

jzuhone
Copy link
Contributor

@jzuhone jzuhone commented May 15, 2023

PR Summary

All this PR does is whitelist the SPH star_formation_rate field so that it automatically gets aliased to "gas" from its SPH particle type.

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

neutrinoceros
neutrinoceros approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should this be labelled as a bugfix or an enhancement ?

@jzuhone jzuhone added the enhancement Making something better label May 15, 2023
@jzuhone
Copy link
Contributor Author

jzuhone commented May 15, 2023

@neutrinoceros enhancement I guess

@neutrinoceros neutrinoceros enabled auto-merge May 15, 2023 16:54
@neutrinoceros neutrinoceros merged commit b87c49f into yt-project:main May 15, 2023
@jzuhone jzuhone deleted the whitelist_sfr branch January 22, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neutrinoceros neutrinoceros neutrinoceros approved these changes

Assignees
No one assigned
Labels
enhancement Making something better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzuhone @neutrinoceros