-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add support for passing field keys for colors and linewidth in streamline plot annotations #4455
ENH: add support for passing field keys for colors and linewidth in streamline plot annotations #4455
Conversation
e1f69a5
to
6ed6529
Compare
6ed6529
to
4786a22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like it!
e0bf5fc
to
217e0cf
Compare
c571955
to
6d899b5
Compare
6d899b5
to
ef85dde
Compare
ef85dde
to
2424f9c
Compare
…streamline plot annotations
2424f9c
to
365b6f5
Compare
had an insignificant conflict, fixed it |
@matthewturk if you're still up for it, this is now ready to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually thought I'd already approved!
you did, I just 'dismissed' your approval when I fixed a conflict ! |
PR Summary
Closes #4454, incidentally fix a couple small issues with
StreamlineCallback
's implementation.demo:
PR Checklist