-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: add support for passing arbitrary kwargs for axes.contours in annotate_contour #4460
base: main
Are you sure you want to change the base?
Conversation
50143f1
to
4ce9e84
Compare
4ce9e84
to
0d106c5
Compare
f8b9cdc
to
8524123
Compare
8524123
to
ff3f265
Compare
I'm going to prioritise #4475 over this. |
ff3f265
to
163f8c2
Compare
163f8c2
to
7d42e11
Compare
rebased to resolve merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an advantage to replacing the plot_args
dict with **kwargs
? My impression is that we had moved away from **kwargs
toward dicts as a means of keeping keywords grouped according to destination. For example, in this same function, we have a text_args
dict. Unless there is a specific benefit, I'm not sure I support this change.
This strategy still has value but it's not necessary to have all arguments be passed through dictionaries: (n-1) dictionaries arguments (with n, the number of destinations) is sufficient ! My point (and proposed change) is that we can still leverage |
The minor benefit I see from keeping |
The way I see it there are three options to choose from:
I don't think any option is ideal: there are precedents to support options 1. and 2., and I have a personal preference to not keep support for more than one API for ever, but maybe option 3. is probably an agreeable middle ground ? |
PR Summary
incidentally fix #4459