BUG: Fix initialization of max level in load_octree #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewturk
changed the title
neutrinoceros
previously approved these changes
Jun 28, 2023
|
I confirm this fixes the issue, but I have ~0 expertise in this area of the code so I'd like to keep this open for a day or two so others can take a look if they want to. |
neutrinoceros
approved these changes
Jul 25, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/yt
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4545.
We don't store the level trait for an Oct as an attribute of the Oct itself, so it has to be collected during the initial traversal. This adds it to the
load_octreecommand via theLoadOctreevisitor, and then it sets an attribute on the dataset. I looked and this only causes problems for the stream octrees.This fixes an issue wherein loading an octree then results in just the root oct being selected regardless of the selection method.