-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Athena++ stretched grids support #4562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome ! I would prefer the new nonuniform
attribute be private, but apart from that, this looks good to me !
I have no idea why the doc builds are failing. |
@jzuhone it's not related to your PR, I tried a build on another PR and got the same error |
I love the simplification in code here. Nice work! It all looks good to me. |
I'll merge this in a minute. Just a note that we need to track down the various issues you linked here and close them as needed. |
Coming back to this. Given the sheer number of issues that are closed by this patch, I now think it could be considered for backporting, despite its unusual size for a bugfix. |
I'd be OK with that, but since it's kind of more of an actual feature I'm not sure it shouldn't just be a minor release. |
PR Summary
This PR provides support for stretched grids in Athena++. I've restored the
test_disk
test that was causing issues before.Closes (or probably closes) several issues, including #1585, #3389, #3619, and #4557, because it removes the buggy code that was previously handling grids with non-uniform cell spacing.
PR Checklist