Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Athena++ stretched grids support #4562

Merged
merged 5 commits into from
Jul 5, 2023

Conversation

jzuhone
Copy link
Contributor

@jzuhone jzuhone commented Jul 4, 2023

PR Summary

This PR provides support for stretched grids in Athena++. I've restored the test_disk test that was causing issues before.

Closes (or probably closes) several issues, including #1585, #3389, #3619, and #4557, because it removes the buggy code that was previously handling grids with non-uniform cell spacing.

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@jzuhone jzuhone added bug enhancement Making something better code frontends Things related to specific frontends labels Jul 4, 2023
@jzuhone jzuhone requested a review from matthewturk July 4, 2023 05:45
@jzuhone jzuhone linked an issue Jul 4, 2023 that may be closed by this pull request
Copy link
Member

@neutrinoceros neutrinoceros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome ! I would prefer the new nonuniform attribute be private, but apart from that, this looks good to me !

@jzuhone
Copy link
Contributor Author

jzuhone commented Jul 4, 2023

I have no idea why the doc builds are failing.

@neutrinoceros
Copy link
Member

@jzuhone it's not related to your PR, I tried a build on another PR and got the same error

@matthewturk
Copy link
Member

I love the simplification in code here. Nice work! It all looks good to me.

@neutrinoceros
Copy link
Member

@jzuhone I have a patch to fix docs build at #4564

I think we can reasonably merge your PR first but if you're not in a hurry it would probably be safer to merge #4564, then rerun docs here.

@jzuhone jzuhone force-pushed the athena_stretched branch from 751e14d to 9bc4ba5 Compare July 5, 2023 16:07
@neutrinoceros
Copy link
Member

I'll merge this in a minute. Just a note that we need to track down the various issues you linked here and close them as needed.

@neutrinoceros
Copy link
Member

Coming back to this. Given the sheer number of issues that are closed by this patch, I now think it could be considered for backporting, despite its unusual size for a bugfix.
What do you think, @matthewturk and @jzuhone ?

@matthewturk
Copy link
Member

I'd be OK with that, but since it's kind of more of an actual feature I'm not sure it shouldn't just be a minor release.

@jzuhone jzuhone deleted the athena_stretched branch January 22, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug code frontends Things related to specific frontends enhancement Making something better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Unreliable AthenaPP position calculations
3 participants