PERF: Add noexcept qualifiers to improve performance on Cython 3 #4581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we instead just get that one in? I don't want to have my commits subsumed into this PR. |
|
#4575 is messy because we're both working on it, so rebasing can only happen once. I'd like to avoid destructive history rewriting, which is why I'm proposing to extract known-good bits instead. |
|
I would prefer we keep the history in this case, even though we are both working on it. I will also admit I was rather taken aback that you took my commits and compressed them into a new PR that was authored by you without first suggesting or asking, and I think I would like to suggest that step not be taken in the future. |
|
Sorry about that, I meant no offense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Extracted from #4575 (patch by @matthewturk)
Partially adresses #4355