Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Sort input file list #4609

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

bmwiedemann
Copy link
Contributor

PR Summary

Sort input file list similar to #2206
so that grid_traversal.cpython-310-x86_64-linux-gnu.so builds in a reproducible way
in spite of non-deterministic filesystem readdir order and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

This PR was done while working on reproducible builds for openSUSE.

so that grid_traversal.cpython-310-x86_64-linux-gnu.so
builds in a reproducible way
in spite of non-deterministic filesystem readdir order
and http://bugs.python.org/issue30461

See https://reproducible-builds.org/ for why this is good.
@neutrinoceros neutrinoceros added the infrastructure Related to CI, versioning, websites, organizational issues, etc label Jul 28, 2023
@neutrinoceros neutrinoceros changed the title Sort input file list BLD: Sort input file list Jul 28, 2023
@neutrinoceros neutrinoceros added the enhancement Making something better label Jul 28, 2023
@neutrinoceros neutrinoceros enabled auto-merge July 28, 2023 17:10
@neutrinoceros neutrinoceros added this to the 4.2.2 milestone Jul 28, 2023
@neutrinoceros
Copy link
Member

Thanks @bmwiedemann !

@neutrinoceros neutrinoceros merged commit 8228771 into yt-project:main Jul 28, 2023
meeseeksmachine pushed a commit to meeseeksmachine/yt that referenced this pull request Jul 28, 2023
@bmwiedemann bmwiedemann deleted the sort2b branch July 28, 2023 18:16
@neutrinoceros neutrinoceros added build related to the build process and removed infrastructure Related to CI, versioning, websites, organizational issues, etc labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build related to the build process enhancement Making something better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants