Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: add support for numpy 2 #4859

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

neutrinoceros
Copy link
Member

PR Summary

numpy 2.0.0rc1 was just released, meaning it's now ABI stable, so we can (and should) start publishing wheels built against.
This is the last blocker for yt 4.3.1

PR Checklist

  • New features are documented, with docstrings and narrative docs
  • Adds a test for any bugs fixed. Adds tests for new features.

@neutrinoceros neutrinoceros added the build related to the build process label Mar 30, 2024
@neutrinoceros neutrinoceros added this to the 4.3.1 milestone Mar 30, 2024
@neutrinoceros
Copy link
Member Author

Ah, I opened it too soon: I'm also working on the ewah-bool-utils release and wheels are still building. Will refresh when it's actually up.

@neutrinoceros neutrinoceros added the enhancement Making something better label Mar 30, 2024
@neutrinoceros neutrinoceros marked this pull request as ready for review March 30, 2024 17:37
chrishavlin
chrishavlin previously approved these changes Apr 1, 2024
@neutrinoceros
Copy link
Member Author

Whoops, I forgot to also bump runtime requirements on ewah.

@chrishavlin
Copy link
Contributor

just in case anyone else looking is initially confused like I was (@neutrinoceros correct me if I'm wrong) -- the tests that run with this PR don't actually end up using np 2.0 because some of yt's dependencies are pinning np<2 still (pandas, scipy, more). but the weekly bleeding edge test does use np 2.0, so we should be in pretty good shape as more dependencies unpin.

@neutrinoceros
Copy link
Member Author

That's right !

@neutrinoceros neutrinoceros merged commit 6d121f5 into yt-project:main Apr 4, 2024
12 checks passed
@neutrinoceros neutrinoceros deleted the bld/support_numpy2.0 branch April 4, 2024 16:12
Copy link

lumberbot-app bot commented Apr 4, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout yt-4.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6d121f58543bedb1f587492cd0601a69f06a736a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #4859: BLD: add support for numpy 2'
  1. Push to a named branch:
git push YOURFORK yt-4.3.x:auto-backport-of-pr-4859-on-yt-4.3.x
  1. Create a PR against branch yt-4.3.x, I would have named this PR:

"Backport PR #4859 on branch yt-4.3.x (BLD: add support for numpy 2)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@neutrinoceros
Copy link
Member Author

Ah, this one is really important to the release so I'll backport manually

neutrinoceros added a commit to neutrinoceros/yt that referenced this pull request Apr 4, 2024
neutrinoceros added a commit to neutrinoceros/yt that referenced this pull request Apr 4, 2024
@neutrinoceros neutrinoceros added the dependencies Pull requests that update a dependency file label Apr 4, 2024
chrishavlin added a commit that referenced this pull request Apr 5, 2024
Backport PR #4859: BLD: add support for numpy 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build related to the build process dependencies Pull requests that update a dependency file enhancement Making something better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants