-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: replace boxlib with amrex references in the docs #4925
DOC: replace boxlib with amrex references in the docs #4925
Conversation
This is inevitably going to hit #4924, but it's also a very timely opportunity to fix it 🤗 |
sure! will add it here |
@@ -558,7 +558,7 @@ using a ``parameters`` dict, accepting the following keys: | |||
AMReX / BoxLib Data | |||
------------------- | |||
|
|||
AMReX and BoxLib share a frontend (currently named ``boxlib``), since | |||
AMReX and BoxLib share a frontend, since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this sentence missing a verb ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ya! good catch, might as well fix that too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(but will wait to see how the docs build goes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verb added to the next line!
just added, didn't pin it to a version though. if the docs build succeeds I can pin it to whatever version it resolves to. |
docs build isn't done, but looks like it's chugging along just fine. I'm going to push up one more batch to fix the small typo that @neutrinoceros caught and pin EDIT: got distracted and hte build finished successfully in the mean time! just pushed the pinned version |
Was building the docs locally and noticed a few spots that should be updated to reflect #4845