Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: skip a flaky test on Windows #4950

Merged

Conversation

neutrinoceros
Copy link
Member

@neutrinoceros neutrinoceros commented Jul 21, 2024

PR Summary

This single test has been flaky for at least weeks and caused a lot of jobs to fail when really it's no big deal if this cannot be consistently tested on windows, so let's just skip it there.
example logs

@neutrinoceros neutrinoceros added tests: running tests Issues with the test setup bug labels Jul 21, 2024
@neutrinoceros neutrinoceros marked this pull request as ready for review July 21, 2024 11:10
@neutrinoceros

This comment has been minimized.

@neutrinoceros neutrinoceros deleted the tst/windows/skip_flaky_test branch July 21, 2024 16:42
@neutrinoceros
Copy link
Member Author

Not the PR I meant to close

@neutrinoceros neutrinoceros restored the tst/windows/skip_flaky_test branch July 21, 2024 19:52
@neutrinoceros neutrinoceros reopened this Jul 21, 2024
Copy link
Contributor

@chrishavlin chrishavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent :)

@neutrinoceros neutrinoceros merged commit c86781b into yt-project:main Jul 23, 2024
22 checks passed
@neutrinoceros neutrinoceros deleted the tst/windows/skip_flaky_test branch July 23, 2024 08:30
@neutrinoceros neutrinoceros added this to the 4.4.0 milestone Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug tests: running tests Issues with the test setup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants