-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: test on Python 3.11 #163
Conversation
So, the state of affairs currently is that builds fail at compile time, but unfortunately it fails even sooner on my machine because I can't even install h5py from source on macOS. Currently I don't think I'll be able to disentangle this before wheels are available for h5py + Python 3.11 |
Appears to be a linking problem
|
Another problem I'm seeing locally (turns out I can try and compile with Maybe I can try to fix this first, since I can iterate locally |
04bb089
to
bcc1929
Compare
Wheels are up and running, but the linking problem on circleci is still here. I've tried to reinstall the "missing" header files via |
The more I think about it the less I understand this failure; it must be a problem with the docker image that's used for Python 3.11, and the right call is probably just to report to CircleCI directly. |
664cb7f
to
859e51c
Compare
Following an exchange with CircleCI's support, here's the report upstream CircleCI-Public/cimg-base#226 |
11ff28a
to
bb33be8
Compare
bb33be8
to
585b707
Compare
I intend to take the important bits from this into the next bugfix release but not necessarily the whole thing |
h5py doesn't even compile from source anymore. The repo seems quite active these days so I'll try again soon |
627b1fc
to
585b707
Compare
9c8ceed
to
e0afbbe
Compare
So there are two main difficulties with testing on Python 3.11 with Circle CI:
|
@brittonsmith any chance we can move this repo to github actions? |
@jzuhone AFAIC feel free to give it a shot, but it won't help with the current blocker |
h5py 3.8 was just released with 3.11 wheels, let's give this another shot ! |
closing/reopening doesn't retrigger circleci, so I'll force-push instead |
a59438e
to
06a900e
Compare
This is now stable, I'll include it in a bugfix release |
@jzuhone, I have no objections to moving the testing to actions, but also no bandwidth to do it. I'm more than happy for it to happen if you'd like to give it a try. @neutrinoceros, as far as I understand, the main repo of rockstar-galaxies will never be updated again. It's even missing a crucial, but minor bugfix that only exists in John Wise's repo. This is noted in the yt-astro install docs. Previously, yt-project maintained an older version of rockstar for similar reasons. I would prefer not to have to do that. Maybe the new "upsteam" could be John's repo. I'm pretty sure he would accept pull requests. |
My goal here is to start testing on Python 3.11
I except this will be a little challenging because: