Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Fix HaloCatalog progress bar #40

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

brittonsmith
Copy link
Member

The HaloCatalog progress bar had an unnecessary update call and was missing a finish call.

@codecov-io
Copy link

codecov-io commented Nov 29, 2018

Codecov Report

Merging #40 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   65.36%   65.28%   -0.08%     
==========================================
  Files          24       24              
  Lines        1305     1305              
==========================================
- Hits          853      852       -1     
- Misses        452      453       +1
Impacted Files Coverage Δ
tests/test_flake8.py 88.23% <0%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7d61f6...bfcda83. Read the comment docs.

@brittonsmith
Copy link
Member Author

This is a fairly simple PR. Any objections to merging?

@ngoldbaum ngoldbaum merged commit 8bbf3ed into yt-project:master Jan 18, 2019
@brittonsmith brittonsmith deleted the pbar branch January 18, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants