clarify rockstar error message about using the wrong number of MPI processes #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
force-pushed
the
rockstar-error
branch
from
710068a to
11457c4
Compare
matthewturk
approved these changes
Jan 25, 2019
|
@brittonsmith would you be ok with merging this despite the failing tests? We should probably look into figuring out why the tests are hanging. I'm happy to help out with that if you are swamped with other things. |
|
Sure, I think it's fine to merge this. I've made a little progress on the testing issue but will sync up with you on slack about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the error message show up in the RuntimeError instead of the logging stream (which might be turned off). I also tried to phrase the error message in a clearer way.