Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check derived_field_list for base fields #43

Merged
merged 1 commit into from
Feb 26, 2019
Merged

check derived_field_list for base fields #43

merged 1 commit into from
Feb 26, 2019

Conversation

ngoldbaum
Copy link
Member

Some frontends (e.g. AHF) don't use these field names in ds.field_list and instead set up aliases. These fields are still in derived_field_list and are accessible so the fix is just to look in derived_field_list.

matthewturk
matthewturk reviewed Feb 26, 2019
View reviewed changes
Copy link
Member

@matthewturk matthewturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to check both?

@ngoldbaum
Copy link
Member Author

Nope, derived_field_list is always a superset of field_list.

brittonsmith
brittonsmith approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@brittonsmith brittonsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch, Nathan.

@brittonsmith brittonsmith merged commit c9f9608 into yt-project:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brittonsmith brittonsmith brittonsmith approved these changes

@matthewturk matthewturk matthewturk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngoldbaum @matthewturk @brittonsmith