Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HaloCatalog refactor and improvements #62

Merged
merged 43 commits into from
Mar 19, 2021
Merged

HaloCatalog refactor and improvements #62

merged 43 commits into from
Mar 19, 2021

Conversation

brittonsmith
Copy link
Member

@brittonsmith brittonsmith commented Apr 27, 2020 •
edited
Loading

This PR represents a series of improvements to the HaloCatalog. This represents most of the work outlined in the HaloCatalog refactor project.

Enhancements:

This also resolves Issue #71.

@brittonsmith
Move pipeline loop into _analyze_halos function.
0cf20a2
@brittonsmith
Refactor saving of fof and hop catalogs.
b947ed8
@brittonsmith
Do not load/return ds for rockstar.
85bfc78
@brittonsmith
Set rockstar outbase with HaloCatalog output_dir.
fc32f60
@brittonsmith
Only set data_source when doing analysis.
788920d
@brittonsmith
Iterate over pre-outputs so to not load each ds.
83d6c66
@brittonsmith
Allow hop and fof halo finding methods to operate on timeseries.
a217315
@brittonsmith
Simplify halo_index since we stop after halo finding now.
da06adf
@brittonsmith
Remove dataset suffix from output name.
2f61994
@brittonsmith
Refactor HaloCatalog as subclass of AnalysisPipeline and implement ha…
efb03bc 
…lo loop with io chunks.
@brittonsmith
Set derived fields as a list.
155bc38
@brittonsmith
Implement looping over io chunks and rearrange deck chairs.
c68ef14
@brittonsmith
Implement _yield_targets for looping.
6d7669a
@brittonsmith
Finish functional abstraction of HaloCatalog into AnalysisPipeline.
cc1df6e
@brittonsmith
Add basename and basedir properties and implement preprocess to creat…
11c4fe7 
…e output dirs.
@brittonsmith
Move load and create to AnalysisPipeline.
b6809a6
@brittonsmith
Rename kwargs.
b747ef4
@brittonsmith
Move halo_finding into halo_analysis.
9249463
@brittonsmith
Move halo catalog files into sub directory.
d7c7bb6
@brittonsmith
Move imports to __init__.
f09ef98
@brittonsmith
Move utility function.
f8f5415
@brittonsmith
Updating imports and removing two halo_quantities that were never ful…
64be62e 
…ly implemented.
@brittonsmith
Add deprecation warning for direct halo finder imports.
070f7e4
@brittonsmith
Moving halo finding tests.
470e3c7
@brittonsmith
Fix halo_finding paths in setup.py.
afad4c1
@brittonsmith
Fix some flake8 errors and return some kwargs I removed.
5eaf49f
@brittonsmith
Get output name from ds, if provided.
f58938a
@brittonsmith
Merge with master.
8573bdd
@brittonsmith
Split functionality between HaloCatalog and AnalysisPipeline classes.
d2a000c
@brittonsmith
Update circleci script.
e3d7cc2
@brittonsmith brittonsmith changed the title [WIP] HaloCatalog refactor and improvements HaloCatalog refactor and improvements Mar 12, 2021
@brittonsmith brittonsmith merged commit 98524c5 into yt-project:master Mar 19, 2021
This was referenced Mar 19, 2021
Closed
Closed
Closed
Closed
Closed
@brittonsmith brittonsmith deleted the hcnew branch March 19, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brittonsmith