Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Add max_box_fraction to plan_cosmology_splice. #76

Merged
merged 1 commit into from
Apr 8, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions yt_astro_analysis/cosmological_observation/cosmology_splice.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ def create_cosmology_splice(self, near_redshift, far_redshift,
return cosmology_splice

def plan_cosmology_splice(self, near_redshift, far_redshift,
max_box_fraction=1.0,
decimals=3, filename=None,
start_index=0):
r"""Create imaginary list of redshift outputs to maximally
Expand All @@ -244,6 +245,15 @@ def plan_cosmology_splice(self, near_redshift, far_redshift,
The nearest (lowest) redshift in the cosmology splice list.
far_redshift : float
The furthest (highest) redshift in the cosmology splice list.
max_box_fraction : float
In terms of the size of the domain, the maximum length a light
ray segment can be in order to span the redshift interval from
one dataset to another. If using a zoom-in simulation, this
parameter can be set to the length of the high resolution
region so as to limit ray segments to that size. If the
high resolution region is not cubical, the smallest side
should be used.
Default: 1.0 (the size of the box)
decimals : int
The decimal place to which the output redshift will be rounded.
If the decimal place in question is nonzero, the redshift will
Expand All @@ -264,6 +274,8 @@ def plan_cosmology_splice(self, near_redshift, far_redshift,

"""

self.max_box_fraction = max_box_fraction

z = far_redshift
outputs = []

Expand Down