Remove the sunyaev_zeldovich analysis module #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brittonsmith
approved these changes
Jul 12, 2021
|
This is perfectly fine with me. Thanks for thinking about this. We've not been testing it since yt-astro spun off, so I think it's fine to just do this. We can leave this open for a little while in case there are other opinions. |
matthewturk
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this module work requires some non-trivial installation procedures which are not amenable to simple pip or conda installing, and it also needs some work. I don't want this to hold up the 4.0-ready version of the package, so I'm proposing we remove it and it should go into its own repository which I will support.