Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: migrate most of setup.py to setup.cfg #90

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

neutrinoceros
Copy link
Member

No description provided.

@neutrinoceros neutrinoceros marked this pull request as ready for review October 13, 2021 15:33
@brittonsmith brittonsmith merged commit d3ebd1c into yt-project:main Oct 13, 2021
@neutrinoceros neutrinoceros deleted the setup_cfg_formatting branch October 13, 2021 15:45
@chummels
Copy link
Member

Is this the preferred way of doing things now? If so, I can do something similar with Trident, but I wasn't aware of this trend of moving setup.py to setup.cfg.

@neutrinoceros
Copy link
Member Author

neutrinoceros commented Oct 13, 2021

it's not widely used. Most projects use setup.py and that's it. In yt we migrated static metadata to setup.cfg because

  1. it enables formatting them with https://github.com/asottile/setup-cfg-fmt + pre-commit
  2. migration can be (semi) automatically performed using https://github.com/asottile/setup-py-upgrade, which reduces the risk of human mistake slipping in

@chummels
Copy link
Member

OK, that makes sense. Thanks for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants