Add annotate_halos function #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is largely just copied and pasted from yt. I'm only going to ask for a quick review as I've cut down the previously cumbersome documentation. |
brittonsmith
force-pushed
the
callback
branch
from
aa08cbc to
87f4441
Compare
for more information, see https://pre-commit.ci
chummels
approved these changes
Oct 16, 2021
matthewturk
approved these changes
Oct 16, 2021
|
This seems doubly approved and ready to go. The only failing test is just that there is slightly less docs coverage than pre-PR, which I think is OK. Is there any reason not to merge this? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the halo catalog callback here so we can remove it from yt (Issue #93).
Once this is merged, it can be deprecated/removed/etc from yt.