Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FXNetworks URL falling back to generic downloader #23754

Closed
5 tasks done
cas4 opened this issue Jan 16, 2020 · 3 comments · Fixed by #26826
Closed
5 tasks done

FXNetworks URL falling back to generic downloader #23754

cas4 opened this issue Jan 16, 2020 · 3 comments · Fixed by #26826

Comments

@cas4
Copy link

cas4 commented Jan 16, 2020

Checklist

  • I'm reporting a broken site support
  • I've verified that I'm running youtube-dl version 2020.01.15
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar issues including closed ones

Verbose log

youtube-dl.exe --verbose --hls-prefer-native -o ".\Movies\The Star.mp4" --ap-mso Comcast_SSO --ap-username **** --ap-password *** http://fxnow.fxnetworks.com/movies-and-specials/the-star
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', '--hls-prefer-native', '-o', '.\\Movies\\The Star.mp4', '--ap-mso', 'Comcast_SSO', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', 'http://fxnow.fxnetworks.com/movies-and-specials/the-star']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2020.01.15
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg N-61620-ge555e1b, ffprobe git-2017-12-23-d02289c
[debug] Proxy map: {}
[generic] the-star: Requesting header
[redirect] Following redirect to https://fxnow.fxnetworks.com/movies-and-specials/the-star
[generic] the-star: Requesting header
WARNING: Falling back on generic information extractor.
[generic] the-star: Downloading webpage
[generic] the-star: Extracting information
ERROR: Unsupported URL: https://fxnow.fxnetworks.com/movies-and-specials/the-star
Traceback (most recent call last):
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp43n_zyg3\build\youtube_dl\YoutubeDL.py", line 796, in extract_info
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp43n_zyg3\build\youtube_dl\extractor\common.py", line 530, in extract
  File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmp43n_zyg3\build\youtube_dl\extractor\generic.py", line 3347, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://fxnow.fxnetworks.com/movies-and-specials/the-star

Description

FX Networks URL must have changed since it is now falling back to the generic downloader.

@tv21
Copy link

tv21 commented Sep 28, 2020

I have also experienced this. It appears to me that they are now using nearly the same format as the disn⋸y network, but not quite. If someone could figure out how to correctly parse the URL, maybe the disn⋸y network extractor would work. Compare these two example URL's (the show name has been concealed by #### in both cases):

https://disn⋸ynow.com/shows/####/season-01/episode-01-title-of-the-show/vdka1??????2

https://fxnow.fxnetworks.com/shows/####/episode-guide/season-01/episode-01-title-of-the-show/vdka3??????4

So the URL's are nearly identical, the only differences are

  • fxnow.fxnetworks.com replaces disn⋸ynow.com
  • /episode-guide/ appears between the show name and season

Also if you use wget to get a fxnetworks.com link you see the string disn⋸y in there several times, which also makes me think maybe the disn⋸y network extractor should be the one being used now, but I'm not a programmer and don't really understand how the extractors parse a URL.

@JamKage
Copy link
Contributor

JamKage commented Oct 6, 2020

Hi @tv21, had a look for you on the back of #22820 and it ended up being pretty trivial to add the FXNetworks brand to the Go extractor as well. Submitted a PR to fix.

@tv21
Copy link

tv21 commented Oct 12, 2020

Hi @tv21, had a look for you on the back of #22820 and it ended up being pretty trivial to add the FXNetworks brand to the Go extractor as well. Submitted a PR to fix.

Thanks, I very much appreciate it but it doesn't seem to work for me, probably because some FX shows use a different URL format than your example URL. Please see my comment on your PR. I suspect it would be fairly trivial to make that format work also if you know what you are doing, but I don't. Thank you again for taking a crack at this.

remitamine pushed a commit that referenced this issue Dec 27, 2020
Co-authored-by: James Kirrage <james.kirrage@mortgagegym.com>

closes #13972
closes #22467
closes #23754
ThirumalaiK pushed a commit to ThirumalaiK/youtube-dl that referenced this issue Jan 28, 2021
Co-authored-by: James Kirrage <james.kirrage@mortgagegym.com>

closes ytdl-org#13972
closes ytdl-org#22467
closes ytdl-org#23754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants