-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reopen issue #24478 - Teachable extractor for 365datascience #24507
Comments
yeah the layout is changed I've been looking for same though |
Hi: I am new to this (github, phyton...) I don´t know the rules so apologies in advanced if I am doing wrong writting in here. I experienced the same problem indicated and did a bit of research on web page code and the extractor teachable.py by @dstftw and @bbepis It seems that the extractor looks for the class 'fa fa-youtube-play' (play icon in red pen above) to identify relevant content to be downloaded but, in some cases maybe by webmaster mistake, relevant content (videos to be downloaded) have the bulb icon (in blue pen above).
However (maybe) some items marked with a bulb could be not relevant if they have no video inside or maybe some other icon or class could be used in the future. The unique feature to do a good match seems that all items with video inside have the time lenght of it in the list, for example (8:13) Time lenght is indicate in 'lecture-name'_ that belongs to the "li" analyzed in
I tried to make some changes in the code an run it but I am unable to go further as I have 0 experience with phyton and very low programming knowledge. So here is my suggestion hoping to help: In teachable.py: Change it to search a regular expression like Best regards and thanks for this marvelous program. |
Checklist
Verbose log
Description
You asked for credentials and closed the issue #24478
I add the credentials in a comment.. so can you reopen it?
--Account credentials: josemanuel32@ztahoewgbo.com:Ates9509
-here is the old description:
link of course that I tried: Intro to Data and Data Science
The text was updated successfully, but these errors were encountered: