Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reopen issue #24478 - Teachable extractor for 365datascience #24507

Closed
6 tasks done
abdullahal25 opened this issue Mar 28, 2020 · 2 comments
Closed
6 tasks done

reopen issue #24478 - Teachable extractor for 365datascience #24507

abdullahal25 opened this issue Mar 28, 2020 · 2 comments

Comments

@abdullahal25
Copy link

Checklist

  • I'm reporting a broken site support issue
  • I've verified that I'm running youtube-dl version 2020.03.24
  • I've checked that all provided URLs are alive and playable in a browser
  • I've checked that all URLs and arguments with special characters are properly quoted or escaped
  • I've searched the bugtracker for similar bug reports including closed ones
  • I've read bugs section in FAQ

Verbose log

[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-u', 'PRIVATE', '-p', 'PRIVATE', '-F', '--no-check-certificate', 'https://365datascience.teachable.com/courses/361452', '-v']
[debug] Encodings: locale cp1256, fs mbcs, out cp720, pref cp1256
[debug] youtube-dl version 2020.03.24
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17134
[debug] exe versions: ffmpeg git-2020-02-16-8578433, ffprobe git-2020-02-16-8578433
[debug] Proxy map: {}
[generic] 361452: Requesting header
[redirect] Following redirect to https://365datascience.teachable.com/p/intro-to-data-and-data-science
[generic] intro-to-data-and-data-science: Requesting header
WARNING: Falling back on generic information extractor.
[generic] intro-to-data-and-data-science: Downloading webpage
[generic] intro-to-data-and-data-science: Extracting information
[TeachableCourse] Downloading 365datascience.teachable.com login page
[TeachableCourse] Logging in to 365datascience.teachable.com
[TeachableCourse] intro-to-data-and-data-science: Downloading webpage
[download] Downloading playlist: Intro to Data and Data Science
[TeachableCourse] playlist Intro to Data and Data Science: Collected 5 video ids (downloading 5 of them)
[download] Downloading video 1 of 5
[Teachable] Downloading 365datascience.teachable.com login page
[Teachable] 5638888: Downloading webpage
[download] Downloading playlist: Welcome to Intro to Data and Data Science
[Teachable] playlist Welcome to Intro to Data and Data Science: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[Wistia] l2jjrj0ew7: Downloading JSON metadata
[info] Available formats for l2jjrj0ew7:
format code   extension  resolution note
mp4-224p      mp4        400x224     329k , mp4 container, h264, 1.60MiB
iphone-360p   mp4        640x360     670k , mp4 container, h264, 3.26MiB
md_mp4-540p   mp4        960x540     836k , mp4 container, h264, 4.06MiB
hd_mp4-720p   mp4        1280x720   1203k , mp4 container, h264, 5.85MiB
hd_mp4-1080p  mp4        1920x1080  2379k , mp4 container, h264, 11.56MiB
original      mp4        1920x1080  10256k , 49.84MiB (best)
[download] Finished downloading playlist: Welcome to Intro to Data and Data Science
[download] Downloading video 2 of 5
[Teachable] 5537196: Downloading webpage
[download] Downloading playlist: Traditional Data: Real-life Examples
[Teachable] playlist Traditional Data: Real-life Examples: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[Wistia] ef6fjmbkij: Downloading JSON metadata
[info] Available formats for ef6fjmbkij:
format code   extension  resolution note
mp4-224p      mp4        400x224     200k , mp4 container, h264, 2.56MiB
iphone-360p   mp4        640x360     307k , mp4 container, h264, 3.92MiB
md_mp4-540p   mp4        960x540     384k , mp4 container, h264, 4.90MiB
hd_mp4-720p   mp4        1280x720    525k , mp4 container, h264, 6.71MiB
hd_mp4-1080p  mp4        1920x1080   813k , mp4 container, h264, 10.39MiB
original      mp4        1920x1080  1548k , 19.77MiB (best)
[download] Finished downloading playlist: Traditional Data: Real-life Examples
[download] Downloading video 3 of 5
[Teachable] 5537224: Downloading webpage
[download] Downloading playlist: Big Data: Real-life Examples
[Teachable] playlist Big Data: Real-life Examples: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[Wistia] ad2ppqpeu1: Downloading JSON metadata
[info] Available formats for ad2ppqpeu1:
format code   extension  resolution note
mp4-224p      mp4        400x224     187k , mp4 container, h264, 2.10MiB
iphone-360p   mp4        640x360     273k , mp4 container, h264, 3.07MiB
md_mp4-540p   mp4        960x540     331k , mp4 container, h264, 3.74MiB
hd_mp4-720p   mp4        1280x720    458k , mp4 container, h264, 5.16MiB
hd_mp4-1080p  mp4        1920x1080   677k , mp4 container, h264, 7.63MiB
original      mp4        1920x1080  1372k , 15.44MiB (best)
[download] Finished downloading playlist: Big Data: Real-life Examples
[download] Downloading video 4 of 5
[Teachable] 5537246: Downloading webpage
[download] Downloading playlist: Business Intelligence (BI): Real-life Examples
[Teachable] playlist Business Intelligence (BI): Real-life Examples: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[Wistia] x1nh89ldqi: Downloading JSON metadata
[info] Available formats for x1nh89ldqi:
format code   extension  resolution note
mp4-224p      mp4        400x224     231k , mp4 container, h264, 2.90MiB
iphone-360p   mp4        640x360     342k , mp4 container, h264, 4.29MiB
md_mp4-540p   mp4        960x540     468k , mp4 container, h264, 5.87MiB
hd_mp4-720p   mp4        1280x720    657k , mp4 container, h264, 8.25MiB
hd_mp4-1080p  mp4        1920x1080  1090k , mp4 container, h264, 13.67MiB
original      mp4        1920x1080  3481k , 43.65MiB (best)
[download] Finished downloading playlist: Business Intelligence (BI): Real-life Examples
[download] Downloading video 5 of 5
[Teachable] 5537270: Downloading webpage
[download] Downloading playlist: Traditional Methods: Real-life Examples
[Teachable] playlist Traditional Methods: Real-life Examples: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[Wistia] ypx6a0ntig: Downloading JSON metadata
[info] Available formats for ypx6a0ntig:
format code   extension  resolution note
mp4-224p      mp4        400x224     197k , mp4 container, h264, 3.99MiB
iphone-360p   mp4        640x360     338k , mp4 container, h264, 6.85MiB
md_mp4-540p   mp4        960x540     381k , mp4 container, h264, 7.73MiB
hd_mp4-720p   mp4        1280x720    533k , mp4 container, h264, 10.81MiB
hd_mp4-1080p  mp4        1920x1080   865k , mp4 container, h264, 17.52MiB
original      mp4        1920x1080  2124k , 43.02MiB (best)
[download] Finished downloading playlist: Traditional Methods: Real-life Examples
[download] Finished downloading playlist: Intro to Data and Data Science

Description

You asked for credentials and closed the issue #24478
I add the credentials in a comment.. so can you reopen it?

--Account credentials: josemanuel32@ztahoewgbo.com:Ates9509

-here is the old description:

Teachable extractor extract only videos which have "fa fa-youtube-play" icon.. other videos which have "fa fa-lightbulb-o" icon aren't be extracted
fff

link of course that I tried: Intro to Data and Data Science

@SwapnilSoni1999
Copy link

yeah the layout is changed I've been looking for same though

@Burikabro
Copy link

Hi: I am new to this (github, phyton...) I don´t know the rules so apologies in advanced if I am doing wrong writting in here.

I experienced the same problem indicated and did a bit of research on web page code and the extractor teachable.py by @dstftw and @bbepis

It seems that the extractor looks for the class 'fa fa-youtube-play' (play icon in red pen above) to identify relevant content to be downloaded but, in some cases maybe by webmaster mistake, relevant content (videos to be downloaded) have the bulb icon (in blue pen above).

<i class='fa fa-youtube-play'></i> "play icon"
<i class='fa fa-lightbulb-o'></i> " bulb icon"

However (maybe) some items marked with a bulb could be not relevant if they have no video inside or maybe some other icon or class could be used in the future. The unique feature to do a good match seems that all items with video inside have the time lenght of it in the list, for example (8:13)

Time lenght is indicate in 'lecture-name'_ that belongs to the "li" analyzed in teachable.py
Web examples:
<span class="lecture-name"> Traditional Data: Techniques (8:13) </span> </div> </a> </li>

<span class='lecture-name'> Analysis vs Analytics (3:50) </span> </div> </a> </li>

I tried to make some changes in the code an run it but I am unable to go further as I have 0 experience with phyton and very low programming knowledge. So here is my suggestion hoping to help:

In teachable.py:
Inside def _real_extract(self, url): (line 250)
Line 272 if 'fa-youtube-play' not in li:

Change it to search a regular expression like \(\d{1,2}:\d\d\) or add a second condition to the if to search also fa fa-lightbulb-o

Best regards and thanks for this marvelous program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants