Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blinkx] Return could be improved to be more future proof #28941

Closed
3 tasks done
abayet opened this issue May 1, 2021 · 0 comments
Closed
3 tasks done

[Blinkx] Return could be improved to be more future proof #28941

abayet opened this issue May 1, 2021 · 0 comments

Comments

@abayet
Copy link

abayet commented May 1, 2021

Checklist

  • I'm reporting a site feature request
  • I've verified that I'm running youtube-dl version 2021.04.26
  • I've searched the bugtracker for similar site feature requests including closed ones

Description

In the blinkx.py extractor, the returned dictionary as it is generated in the _real_extract() function would make the execution crash if the layout of the source data changed for optional fields. There it is a screenshot of the problematic portion of code.

image

The optional fields "uploader" (line 81) and "timestamp" (line 82) are concerned. As mentioned in the youtube-dl coding conventions, it would more robust to use the method get().

pukkandan added a commit to yt-dlp/yt-dlp that referenced this issue May 4, 2021
@dstftw dstftw closed this as completed in a726009 May 4, 2021
fossdd pushed a commit to ex-dl/ex-dl that referenced this issue May 10, 2021
nixxo pushed a commit to nixxo/yt-dlp that referenced this issue Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant