Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split youtube-dl on several modules #29

Closed
vvavrychuk opened this issue Dec 5, 2010 · 2 comments
Closed

split youtube-dl on several modules #29

vvavrychuk opened this issue Dec 5, 2010 · 2 comments

Comments

@vvavrychuk
Copy link
Contributor

It is worth to split youtube-dl on several modules, e.g. youtube.py, metacafe.py, dailymotion.py and so on. Then it is possible to add "makefile" which will combine those files into youtube-dl file.

This approach is applied in https://github.com/sstephenson/prototype library for example.
As a rakefile analogue can be used distutils, scons.

By splitting youtube-dl it will be more easy to read, more easy to merge and source will not blow up in the case of adding support of lots new sites.

What do you think?

@rg3
Copy link
Collaborator

rg3 commented Dec 5, 2010

Sorry, but that won't happen. I want users to be able to simply download a single file to deploy the program on any platform. Your approach defeats the purpose, and the codebase is small.

@vvavrychuk
Copy link
Contributor Author

Sure, user will be able to download single youtube-dl. Thats why setup.py is needed. Upon every release you can update youtube-dl by calling 'python setup.py' which will combine all *.py to youtube-dl. Then you can put youtube-dl to website repository.

Final desicion is of course after you. Please treat this issues just as a suggestion.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants