Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liveleak: add original format without watermark #17625

Closed
wants to merge 1 commit into from

Conversation

jomo
Copy link
Contributor

@jomo jomo commented Sep 21, 2018

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

LiveLeak video filenames commonly look somewhat like something.mp4.zxcvbn.mp4, which has a watermark and lower quality compared to something.mp4.

This PR adds an additional format that uses the original filename where possible.

youtube_dl/extractor/liveleak.py Outdated Show resolved Hide resolved
youtube_dl/extractor/liveleak.py Outdated Show resolved Hide resolved
youtube_dl/extractor/liveleak.py Outdated Show resolved Hide resolved
@jomo
Copy link
Contributor Author

jomo commented Sep 23, 2018

I think I have addressed all your change requests, @dstftw. Can you take a look?

@jomo
Copy link
Contributor Author

jomo commented Sep 26, 2018

@dstftw anything else you want me to change?

@dstftw dstftw force-pushed the master branch 2 times, most recently from 7b956a1 to 5e26784 Compare September 13, 2020 13:51
@dstftw dstftw closed this in 379f52a Jun 20, 2021
gaming-hacker added a commit to gaming-hacker/youtube-dl that referenced this pull request Sep 3, 2021
* commit '188b7b108e1cd287580bee5dba8075e669c29a10': (192 commits)
  Avoid skipping ID when unlisted_hash is numeric
  [peertube] only call description endpoint if necessary (ytdl-org#29383)
  [periscope] pass referer to HLS requests(closes ytdl-org#29419)
  [liveleak] Remove extractor (closes ytdl-org#17625, closes ytdl-org#24222) (ytdl-org#29331)
  [pornhub] Add support for pornhubthbh7ap3u.onion
  [pornhub] Detect geo restriction
  [pornhub] Dismiss tbr extracted from download URLs (closes ytdl-org#28927)
  [curiositystream:collection] Extend _VALID_URL (closes ytdl-org#26326, closes ytdl-org#29117)
  [youtube] Make get_video_info processing more robust (closes ytdl-org#29333)
  [youtube] Workaround for get_video_info request (refs ytdl-org#29333)
  [bilibili] Strip uploader name (ytdl-org#29202)
  [youtube] Update invidious instance list (ytdl-org#29281)
  [umg:de] Update GraphQL API URL (ytdl-org#29304)
  [nrk] Switch psapi URL to https (closes ytdl-org#29344)
  [postprocessor/ffmpeg] Show ffmpeg output on error (refs ytdl-org#22680) (ytdl-org#29336)
  [egghead] Add support for app.egghead.io (closes ytdl-org#28404) (ytdl-org#29303)
  [appleconnect] Fix extraction (ytdl-org#29208)
  [orf:tvthek] Add support for MPD formats (closes ytdl-org#28672) (ytdl-org#29236)
  [README.md] Update MSVC 2010 redist URL (closes ytdl-org#29222)
  release 2021.06.06
  ...

# Conflicts:
#	youtube_dl/extractor/generic.py
@Lesmiscore Lesmiscore mentioned this pull request Feb 20, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants