[beampro] Added support for Mixer clips #23061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheGilias
changed the title
|
FYI I have tested and verified that this extractor still works even after Mixer's clipping enhancements they announced yesterday. |
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
closes ytdl-org#17290 closes ytdl-org#22871 closes ytdl-org#23020 closes ytdl-org#23061 closes ytdl-org#26099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This code update adds support for Mixer clips to the existing beampro.py extractor under the new class name BeamProClipIE. It retrieves the clip manifest from Mixer's API and returns information to the extractor for where the clip can be downloaded. I authored this code myself using BeamProVodIE as a template. This is literally the first open-source contribution I've ever done on Github so I'm new to this. Let me know if I've done something wrong or if I can clarify anything for you.