Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[options] assign -V to --version to resolve conflict with --verbose #24162

Merged
merged 2 commits into from
Feb 29, 2020
Merged

[options] assign -V to --version to resolve conflict with --verbose #24162

merged 2 commits into from
Feb 29, 2020

Conversation

Lesmiscore
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This resolves conflict of shorthand of --version and --verbose.
Because -v is widely used for --verbose, this PR changes only --version and keep others unchanged.

@dstftw
Copy link
Collaborator

dstftw commented Feb 28, 2020

There is no need in short option for version at all.

@Lesmiscore
Copy link
Contributor Author

Completely removed.

@dstftw dstftw merged commit b76f0e5 into ytdl-org:master Feb 29, 2020
@ytdl-org ytdl-org deleted a comment from Fabian42 Mar 1, 2020
@ytdl-org ytdl-org locked and limited conversation to collaborators Mar 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants