Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tmz #24687

Closed
wants to merge 3 commits into from
Closed

Fix tmz #24687

wants to merge 3 commits into from

Conversation

diegorodriguezv
Copy link

@diegorodriguezv diegorodriguezv commented Apr 8, 2020

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This fixes #24603.
Videos posted after november 2019 have a description string before the video_id. This is fixed by using the last 10 characters as the video_id. Also the test was failing because the kaltura extractor no longer returns a description.

Articles pages have changed, they no longer have a tmzVideoEmbed function. The page for the kaltura extractor can be obtained from the first parameter to the TMZ.actions.clickLink function, but checking that the page is not the original URL to avoid infinite loops.

I have tested this fix with several pages of different age and works correctly in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some TMZ.com videos are not downloaded
1 participant