Better extraction for nrk #25751
Closed
Better extraction for nrk #25751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get content of meta tag Inspired by, and closes #25594
Can't see why the original method don't work for some streams. Bonus: provides 1080p quality Closes #24221
This is what I consider the actual title
Prevents some long-running series from returning `NA`
It does not need to be in the loop, introduces some duplicated parts of code
Roxedus
force-pushed
the
better_extract_nrk
branch
from
4fba230
to
10664e4
Compare
dstftw
requested changes
Jun 30, 2020
|
|
||
| dur = parse_duration(playback_convia.get('duration')) | ||
| subs = {} | ||
| for sub_title in playback_manifest.get('playable').get('subtitles'): |
| @@ -427,7 +464,8 @@ def _real_extract(self, url): | |||
|
|
|||
| nrk_id = self._parse_json( | |||
| self._search_regex(JSON_LD_RE, webpage, 'JSON-LD', group='json_ld'), | |||
| display_id)['@id'] | |||
| display_id).get('@id') or \ | |||
There was a problem hiding this comment.
Because of the lack of fallback?
|
dstftw
force-pushed
the
master
branch
2 times, most recently
from
5e26784
to
da2069f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This fixes two open issues for the NRK extractor, #25594 and #24221 as well as providing
alt_title, useful for shows that does indeed have unique episode names, rather than<series name> <episode number>:<total episodes in season>In order to fully fix 24221 I had to use a additional endpoint to fetch a m3u8 playlist, this seems to be the endpoint which exposes 1080P quality.
Some test maintenance was also done, the description seems to change from time to time.