[peertube] Extract files also from streamingPlaylists
#26302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON objects with an empty "files" tag seem to be a valid PeerTube API response. In those cases the "files" arrays contained in the "streamingPlaylists" members can be used instead.
dstftw
force-pushed
the
master
branch
2 times, most recently
from
5e26784
to
da2069f
Compare
|
This PR indeed fixes #26002. Please merge. |
remitamine
requested changes
Dec 30, 2020
Comment on lines
+541
to
+542
| files = video['files'] | ||
| for playlist in video['streamingPlaylists']: |
There was a problem hiding this comment.
Suggested change
| files = video['files'] | |
| for playlist in video['streamingPlaylists']: | |
| files = video.get('files') or [] | |
| for playlist in (video.get('streamingPlaylists') or []): |
5 tasks
|
I made an another PR (#27728) because my original repo disappeared after the DMCA take-down. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #26002 some PeerTube instances respond with a seemingly corrupted video descriptor JSON object and the extractor is unable to determine the available file formats in those cases. Turned out that an empty
"files"array caused those kind of problems but, fortunately, there are another"files"arrays in"streamingPlaylists"array which can be used instead.Here is the corresponding part of the API specification:
https://docs.joinpeertube.org/api-rest-reference.html#tag/Video/paths/~1videos~1%7Bid%7D/get