-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Kakao Extractor #26577
Fix Kakao Extractor #26577
Conversation
Kakao has changed their API to return `null` for `clipChapterThumbnailList`, this change comments out the thumbnail extractor to fix the issue.
Why I'm getting this error? |
@zackmark29 That was the error I was getting on the old version of the file, try the new one linked in the commit. I tested with the one in the commit and it works fine. |
Alright. thanks |
Do you have compiled exe version? |
I do not, however you can run |
Ah alright. I'll try. |
Still the same error. I already updated the kakao.py with your updated code. |
That is strange... not sure what would be causing the error then as the affected code is commented out, and I was able to download the video fine on my end. Can you paste the error you got this time (even if it is the same as before)? I would also suggest double-checking to make sure the file is exactly matching what is shown here (especially around line 120 where the change is). |
Thank you it's now working. |
Okay, glad to hear it's working for you now! |
5e26784
to
da2069f
Compare
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Kakao has changed their API to return
null
forclipChapterThumbnailList
, this change comments out the thumbnail extractor to fix the issue.