expose release_year for tubi #27317
Merged
expose release_year for tubi #27317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's sitting in the metadata, may as well use it
tubi will typically report 0 for the release year on information they do not have year data for (individual videos, typically) so defaulting to 0 shouldn't impact anything since it I haven't seen a case where it was absent in the first place
dstftw
requested changes
Dec 8, 2020
youtube_dl/extractor/tubitv.py
Outdated
| @@ -93,4 +103,5 @@ def _real_extract(self, url): | |||
| 'description': video_data.get('description'), | |||
| 'duration': int_or_none(video_data.get('duration')), | |||
| 'uploader_id': video_data.get('publisher_id'), | |||
| 'release_year': int_or_none(video_data.get('year', 0)), | |||
There was a problem hiding this comment.
Lack of data is denoted by None not 0.
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Puts the release_year into the extractor data for tubi.