[Generic] Fix RSS item thumbnail URL #27405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The thumbnail url of an item in RSS feed is in "href" attribute (not directly in the itunes:image tag)
|
Add a test. |
Change upload_date (compat_str previously failed) and add thumbnail
dstftw
requested changes
Dec 13, 2020
youtube_dl/extractor/generic.py
Outdated
| 'duration': float, | ||
| 'thumbnail': None, |
There was a problem hiding this comment.
This make zero sense. You must add a test that will test the changes made.
There was a problem hiding this comment.
@dstftw yes, you are right. Can I add another RSS feed, because this one don't get thumbnail image ?
Or I can update the test of this one http://www.hellointernet.fm/podcast?format=rss ?
There was a problem hiding this comment.
You can use any existing RSS test with thumbnail available or add a new if there are no such tests.
Add unit test to check item thumbnail
|
@dstftw I added a new test. Thanks :-) |
dstftw
requested changes
Dec 17, 2020
|
@dstftw requested change done 😊 |
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thumbnail url of an item in RSS feed is in "href" attribute (not directly in the itunes:image tag)
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
The thumbnail url of an item in RSS feed is in "href" attribute (not directly in the itunes:image tag)