Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vvvvid] fix season title extraction (#27601) #27618

Merged
merged 3 commits into from
Feb 24, 2021
Merged

[vvvvid] fix season title extraction (#27601) #27618

merged 3 commits into from
Feb 24, 2021

Conversation

nixxo
Copy link
Contributor

@nixxo nixxo commented Jan 1, 2021

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Bug fix
  • Improvement

Description of your pull request and other information

fixes #27601

the only place where to find the season "title" is to call the same url used in the playlist extractor and scroll the file looking for the season that the current video beloongs end save the season "title" that way.

It's probably not super efficient or elegant

Or I can extract it in the playlist extractor and use url_transparent to pass it, it's a lot easier and cleaner:

'_type': 'url_transparent',
'ie_key': VVVVIDIE.ie_key(),
...
'season': str_or_none(season.get('name'))

but if you download the single episode you don't have the 'season title' info available.

@nixxo nixxo changed the title [vvvvid] fix season title extraction (#27601) [vvvvid] fix season title extraction (#27601) + youtube support Jan 2, 2021
@nixxo nixxo changed the title [vvvvid] fix season title extraction (#27601) + youtube support [vvvvid] fix season title extraction (#27601) Jan 14, 2021
@nixxo nixxo mentioned this pull request Feb 22, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[vvvvid] Support for "season" name extraction
2 participants