Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrk] add support for podcast episodes (closes #27634) #27635

Closed
wants to merge 2 commits into from

Conversation

barsnick
Copy link

@barsnick barsnick commented Jan 2, 2021

No support for complete series yet.

Signed-off-by: Moritz Barsnick barsnick@gmx.net

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

This adds support of NRK podcasts to the [nrk] extractor. It does not support series yet, only single episodes.

It has worked fine for me for the last eight weeks, on various podcasts.

Implementation notes:

  • transform_source=js_to_json prevent python for choking on special characters in the JSON embedded in webpages.
  • .strip() is required, as one of the tests actually otherwise delivers a title with leading whitespace.
  • I wasn't able to get a thumbnail for one of the tests, therefore the thumbnail metadata code has an or None.

No support for complete series yet.

Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
Missed to check after merge/cherry-pick.

Ignoring error "E128 continuation line under-indented for visual indent" due to
coding style seen elsewhere.

Signed-off-by: Moritz Barsnick <barsnick@gmx.net>
@barsnick
Copy link
Author

barsnick commented Jan 2, 2021

I pushed an additional commit for the flake8 errors in CI. Sorry, I missed them before.

@dstftw
Copy link
Collaborator

dstftw commented Jan 2, 2021

  1. Read coding conventions.
  2. This must use existing extractor working with playback end point.

@dstftw dstftw closed this in 21a42e2 Jan 2, 2021
ThirumalaiK pushed a commit to ThirumalaiK/youtube-dl that referenced this pull request Jan 28, 2021
+ Add support for mp3 formats
* Generalize and delegate all item extractors to nrk, beware ie key breakages
+ Add support for podcasts
+ Generalize nrk shortcut form to support all kind of ids
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants