Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rai] fixes #12652 #27673

Merged
merged 4 commits into from
Jan 5, 2021
Merged

[rai] fixes #12652 #27673

merged 4 commits into from
Jan 5, 2021

Conversation

nixxo
Copy link
Contributor

@nixxo nixxo commented Jan 5, 2021

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense

What is the purpose of your pull request?

  • Improvement

Description of your pull request and other information

fix for #12652

note: splitted the PR as requested here: #27657 (comment)

@nixxo nixxo mentioned this pull request Jan 5, 2021
8 tasks
@@ -410,6 +423,11 @@ def _real_extract(self, url):
''' % self._UUID_RE,
webpage, 'content item id', default=None, group='id')

if not content_item_id:
content_item_id = self._search_regex(
r'/ContentItem-(?P<id>%s)\.html\?iframe' % self._UUID_RE,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add <iframe part to the regex and move this whole pattern to into previous _search_regex call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nixxo nixxo requested a review from dstftw January 5, 2021 18:24
@dstftw dstftw merged commit fcd90d2 into ytdl-org:master Jan 5, 2021
@nixxo nixxo deleted the rai-fix-iframe branch January 7, 2021 13:57
ThirumalaiK pushed a commit to ThirumalaiK/youtube-dl that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants