[ADN] Fix #27732
Merged
[ADN] Fix #27732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remitamine
requested changes
Jan 9, 2021
youtube_dl/extractor/adn.py
Outdated
| if links_data is None: | ||
| raise ExtractorError('Giving up retrying') | ||
|
|
||
| if links_data.get('code') == 'player-bad-geolocation-country': |
There was a problem hiding this comment.
add an only_matching test for this case.
There was a problem hiding this comment.
Afaik everything's not available in Germany. Definitely the existing _TEST.
|
Thanks for the thorough review! This does not address the subtitles situation. |
adrianheine
force-pushed
the
adn
branch
2 times, most recently
from
aee3ea9
to
d0f68c4
Compare
remitamine
requested changes
Jan 9, 2021
ThirumalaiK
pushed a commit
to ThirumalaiK/youtube-dl
that referenced
this pull request
Jan 28, 2021
|
Do you want to be credited as one of the authors of youtube-dl? If so under what name? |
|
Sure, thank you :) That would be »Adrian Heine«. |
remitamine
added a commit
that referenced
this pull request
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Closes #26963. The extractor doesn't work at all currently.