Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore failure to create existing directory #27811

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

bcc32
Copy link

@bcc32 bcc32 commented Jan 14, 2021

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Fix a bug where a video would not be downloaded because creating the destination folder failed due to already existing. This bug can happen when multiple videos are being downloaded to the same destination folder by concurrent youtube-dl processes (e.g., through GNU parallel).

I did not add tests because the fix is for a heisenbug that, by definition, is not possible to write a deterministic test for.

@dstftw dstftw merged commit 8e5477d into ytdl-org:master Jan 14, 2021
@bcc32 bcc32 deleted the fix-race-on-create-existing-directory branch January 14, 2021 05:28
ThirumalaiK pushed a commit to ThirumalaiK/youtube-dl that referenced this pull request Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants