[youporn] Add duration #28019
Merged
[youporn] Add duration #28019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianheine
suggested changes
Feb 3, 2021
youtube_dl/extractor/youporn.py
Outdated
| @@ -153,6 +153,8 @@ def _real_extract(self, url): | |||
| thumbnail = self._search_regex( | |||
| r'(?:imageurl\s*=|poster\s*:)\s*(["\'])(?P<thumbnail>.+?)\1', | |||
| webpage, 'thumbnail', fatal=False, group='thumbnail') | |||
| duration = int_or_none(self._html_search_meta( | |||
| 'video:duration', webpage, 'duration', default=False, fatal=False)) | |||
There was a problem hiding this comment.
If you have default, fatal is not used.
There was a problem hiding this comment.
I did not know, thanks for the tip! I learn something new every time I do something with youtube-dl :) I've removed the default, following the line of the rest of the code in this file.
There was a problem hiding this comment.
I know what you mean :) I think default=None is actually better (without fatal=False). fatal=False makes it emit a warning and return None, while default=None will just silently return None. For optional metadata like duration, I think it's better not to have a warning.
Remove `default=False` for duration.
|
Add a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Add video duration to output