Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[egghead] Fixed egghead extractor - API base URL host updated #28038

Closed
wants to merge 2 commits into from

Conversation

bkvirendra
Copy link

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly
  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])
  • Use Preview tab to see how your pull request will actually look like

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

The Egghead extractor was raising the below exception:
[egghead:course] professor-frisby-introduces-composable-functional-javascript: Downloading course lessons JSON ERROR: Unable to download JSON metadata: HTTP Error 308: Permanent Redirect (caused by HTTPError()); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

The base URL in the extractor ('https://egghead.io/api/v1/series/%s/lessons') for fetching the JSON resource for the metadata was outdated.
I have gone ahead and updated the base URL to point to the updated base URL ('https://app.egghead.io/api/v1/series/%s/lessons').

@bkvirendra bkvirendra changed the title Updated egghead extractor API endpoint + fixes tests Updated egghead extractor API endpoint Feb 1, 2021
@bkvirendra bkvirendra changed the title Updated egghead extractor API endpoint [bugfix] Updated egghead extractor API endpoint Feb 1, 2021
@bkvirendra bkvirendra changed the title [bugfix] Updated egghead extractor API endpoint [bugfix] Fixed egghead extractor Feb 2, 2021
@bkvirendra bkvirendra changed the title [bugfix] Fixed egghead extractor [egghead] Fixed egghead extractor Feb 2, 2021
@bkvirendra bkvirendra changed the title [egghead] Fixed egghead extractor [egghead] Fixed egghead extractor - API base URL host updated Feb 2, 2021
@remitamine remitamine closed this in 0e3a968 Feb 2, 2021
@Miosame Miosame mentioned this pull request Mar 10, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant