[youtube] fixed --flat-playlist always showing uploader as none #28045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks for your PR! Please prefix your commit message (and PR title) with |
PrinceOfPuppers
changed the title
woops sorry, updated. |
PrinceOfPuppers
force-pushed
the
master
branch
from
e7c5de2
to
35b6113
Compare
|
Also got rid of the extra 2 commits i accidentally created when attempting to rename the commit. |
dstftw
requested changes
Feb 13, 2021
|
Add test. |
dstftw
requested changes
Feb 15, 2021
Comment on lines
+70
to
+78
| def test_youtube_flat_playlist_uploaders(self): | ||
| dl = FakeYDL() | ||
| dl.params['extract_flat'] = True | ||
| ie = YoutubeTabIE(dl) | ||
| result = ie.extract('https://www.youtube.com/playlist?list=PL2zzFmCbIz4fshCLrvopue-wDeKQ5ERKO') | ||
| self.assertIsPlaylist(result) | ||
| for entry in result['entries']: | ||
| if entry['title'] not in ('[Deleted video]', '[Private video]'): | ||
| self.assertTrue(entry.get('uploader')) |
There was a problem hiding this comment.
Test should be added to Use one of the youtube-dl's test playlists for testing, e.g. https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc._TESTS of extractor class.
dstftw
pushed a commit
that referenced
this pull request
Feb 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
running:
prior to the bugfix would always have "uploader": none in each playlist item. post fix the proper uploader will appear in said field