Fixes a crash when release_year as well as release_date are None and … #28094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…therefore no year can be retrieved. Before the fix it resulted in failing to cast None to int. I noticed the crash when trying to download an m4a using the parameters -f 140 --skip-unavailable-fragments https://www.youtube.com/watch?v=OtqTfy26tG0&list=PLwpO1O2Nt4_JUxnCuyP9Uz3uDX3fELp3Z&index=36
|
dstftw
requested changes
Feb 6, 2021
| @@ -1735,7 +1735,7 @@ def process_language(container, base_url, lang_code, query): | |||
| 'artist': mobj.group('clean_artist') or ', '.join(a.strip() for a in mobj.group('artist').split('·')), | |||
| 'track': mobj.group('track').strip(), | |||
| 'release_date': release_date, | |||
| 'release_year': int(release_year), | |||
| 'release_year': int(release_year) if release_year else 0, | |||
There was a problem hiding this comment.
- Lack of data is denoted by
None, not 0. - int_or_none.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…therefore no year can be retrieved. Before the fix it resulted in failing to cast None to int. I noticed the crash when trying to download an m4a using the parameters -f 140 --skip-unavailable-fragments https://youtu.be/OtqTfy26tG0
Please follow the guide below
xinto all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.