Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atomicparsley binary lookup #28112

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Fix atomicparsley binary lookup #28112

merged 1 commit into from
Feb 16, 2021

Conversation

nbr23
Copy link

@nbr23 nbr23 commented Feb 8, 2021

Before submitting a pull request make sure you have:

In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:

  • I am the original author of this code and I am willing to release it under Unlicense
  • I am not the original author of this code but it is in public domain or released under Unlicense (provide reliable evidence)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New extractor
  • New feature

Description of your pull request and other information

AtomicParsley (which is required for the --embed-thumbnail flag) is installed as AtomicParsley on most distributions, but can be found as atomicparsley on Alpine for example.
This PR allows youtube-dl to check if either AtomicParsley or atomicparsley named binaries exist on the system.

@nbr23 nbr23 requested a review from dstftw February 13, 2021 23:49
@dstftw dstftw merged commit 646052e into ytdl-org:master Feb 16, 2021
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Feb 22, 2021
…nary file

Now supported by the one package (that I know of) that uses this:
ytdl-org/youtube-dl#28112

git-svn-id: file:///srv/repos/svn-community/svn@868389 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this pull request Feb 22, 2021
…nary file

Now supported by the one package (that I know of) that uses this:
ytdl-org/youtube-dl#28112


git-svn-id: file:///srv/repos/svn-community/svn@868389 9fca08f4-af9d-4005-b8df-a31f2cc04f65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants