Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[utils] Fix handling of comments in js_to_json #28446

Closed
wants to merge 5 commits into from
Closed

[utils] Fix handling of comments in js_to_json #28446

wants to merge 5 commits into from

Commits on Mar 14, 2021

  1. Fix handling of comments in js_to_json (closes ytdl-org#23707, closes y… 

    …tdl-org#23785)
    @TinyToweringTree @marado
    TinyToweringTree authored and marado committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    d57da2e View commit details
    Browse the repository at this point in the history

  2. Fix comment handling in js_to_json for Python <3.5

    @TinyToweringTree @marado
    TinyToweringTree authored and marado committed Mar 14, 2021
    Configuration menu
    Copy the full SHA
    deaf903 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Merge branch 'master' into comments

    @marado
    marado committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    a9dc71c View commit details
    Browse the repository at this point in the history

  2. Use two blank lines instead of just one 

    https://www.python.org/dev/peps/pep-0008/#blank-lines
Fixes: E302 expected 2 blank lines, found 1
    @marado
    marado committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    3cafa15 View commit details
    Browse the repository at this point in the history

  3. remove ! characters from the js_to_json output 

    While this results in wrong values, it is the previous behaviour and
what the tests are currently expecting.
    @marado
    marado committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    62858b3 View commit details
    Browse the repository at this point in the history