[Youtube] Avoid crashing if n-sig decode fails #30585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
When JSInterp-based n-parameter decoding was implemented to replace the temporary fix from derived from VLC, the descrambling code acquired a
try
block that re-raised any exception during descrambling as anExtractorError
. This caused yt-dl to fail if the decoding failed, whereas the program could have continued with a warning and run the download at the throttled rate.This PR changes the re-raised exception to a warning. The warning may be shown as many times as the n-parameter is found in the item's media URLs, but that should be an incentive to patch the program quickly.