-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsinterp] Improve JS language support #31175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* operator ?? * operator ?. * operator ** * accurate operator functions * `undefined` handling * object literals {a: 1, "b": expr}
5 tasks
github-actions bot
added a commit
to hellopony/youtube-dl
that referenced
this pull request
Aug 17, 2022
* https://github.com/ytdl-org/youtube-dl: [jsinterp] Improve JS language support (ytdl-org#31175)
pukkandan
added a commit
to yt-dlp/yt-dlp
that referenced
this pull request
Aug 18, 2022
Code from: ytdl-org/youtube-dl#31175, ytdl-org/youtube-dl#31182 Authored by pukkandan, dirkf
gaming-hacker
added a commit
to gaming-hacker/youtube-dl
that referenced
this pull request
Aug 26, 2022
* commit 'ed5c44e7b74ac77f87ca5ed6cb5e964a0c6a0678': [compat] Replace deficient ChainMap class in Py3.3 and earlier * fix version check [compat] Replace deficient ChainMap class in Py3.3 and earlier [jsinterp] Improve try/catch/finally support [jsinterp] Fix bug in operator precedence * from yt-dlp/yt-dlp@164b03c * added tests [YouTube] Improve error check for n-sig processing [core] Avoid processing empty format list after removing bad formats * also ensure compat encoding of error strings [utils] Ensure RFC3986 encoding result is unicode [infoq] Avoid crash if the page has no `mp3Form` [uktvplay] Support domain without .uktv [jsinterp] Clean up and pull yt-dlp style * add compat_re_Pattern * improve compat_collections_chain_map * use class JS_Undefined * remove unused code [jsinterp] Handle regexp literals and throw/catch execution (ytdl-org#31182) [jsinterp] Improve JS language support (ytdl-org#31175)
belamenso
pushed a commit
to belamenso/youtube-dl
that referenced
this pull request
Sep 19, 2022
* operator ?? * operator ?. * operator ** * accurate operator functions * `undefined` handling * object literals {a: 1, "b": expr} * more tests for weird JS comparisons: see ytdl-org#31173 (comment).
gaming-hacker
added a commit
to gaming-hacker/youtube-dl
that referenced
this pull request
Oct 6, 2022
* commit 'b6bfdb25f200ba63ba1b011a54431cb424be46e9': (23 commits) [jsinterp] Workaround operator associativity issue * temporary fix for player 5a3b6271 [1] [cache] Add cache validation by program version, based on yt-dlp [jsinterp] Handle new YT players 113ca41c, c57c113c * add NaN * allow any white-space character for `after_op` * align with yt-dlp f26af78 (charcodeAt and bitwise overflow) * allow escaping in regex, fixing player c57c113c [options] Document that postprocessing is not forced by --postprocessor-args [compat] Replace deficient ChainMap class in Py3.3 and earlier * fix version check [compat] Replace deficient ChainMap class in Py3.3 and earlier [jsinterp] Improve try/catch/finally support [jsinterp] Fix bug in operator precedence * from yt-dlp/yt-dlp@164b03c * added tests [YouTube] Improve error check for n-sig processing [core] Avoid processing empty format list after removing bad formats * also ensure compat encoding of error strings [utils] Ensure RFC3986 encoding result is unicode [infoq] Avoid crash if the page has no `mp3Form` [uktvplay] Support domain without .uktv [jsinterp] Clean up and pull yt-dlp style * add compat_re_Pattern * improve compat_collections_chain_map * use class JS_Undefined * remove unused code [jsinterp] Handle regexp literals and throw/catch execution (ytdl-org#31182) [jsinterp] Improve JS language support (ytdl-org#31175) [postprocessor] Don't replace existing value with null metadata parsed from title [jsinterp] Overhaul JSInterp to handle new YT players 4c3f79c5, 324f67b9 (ytdl-org#31170) [core] Make `--max-downloads ...` stop immediately on reaching the limit [test, etc] Improve download test logs; also clean up some new flake8 issues (ytdl-org#31153) ...
gaming-hacker
added a commit
to gaming-hacker/youtube-dl
that referenced
this pull request
Oct 19, 2022
* commit '2c0c42cd5c5689eed3dba0c16399c7b3386b44b9': (394 commits) cleaning Improvements Improvement: Readme Fix Crucial guide command leads into errors [jsinterp] Workaround operator associativity issue * temporary fix for player 5a3b6271 [1] [cache] Add cache validation by program version, based on yt-dlp [jsinterp] Handle new YT players 113ca41c, c57c113c * add NaN * allow any white-space character for `after_op` * align with yt-dlp f26af78 (charcodeAt and bitwise overflow) * allow escaping in regex, fixing player c57c113c [options] Document that postprocessing is not forced by --postprocessor-args [compat] Replace deficient ChainMap class in Py3.3 and earlier * fix version check [compat] Replace deficient ChainMap class in Py3.3 and earlier [jsinterp] Improve try/catch/finally support [jsinterp] Fix bug in operator precedence * from yt-dlp/yt-dlp@164b03c * added tests [YouTube] Improve error check for n-sig processing [core] Avoid processing empty format list after removing bad formats * also ensure compat encoding of error strings [utils] Ensure RFC3986 encoding result is unicode [infoq] Avoid crash if the page has no `mp3Form` [uktvplay] Support domain without .uktv [jsinterp] Clean up and pull yt-dlp style * add compat_re_Pattern * improve compat_collections_chain_map * use class JS_Undefined * remove unused code [jsinterp] Handle regexp literals and throw/catch execution (ytdl-org#31182) [jsinterp] Improve JS language support (ytdl-org#31175) ...
alxlive
pushed a commit
to alxlive/youtube-dl
that referenced
this pull request
Feb 27, 2023
* operator ?? * operator ?. * operator ** * accurate operator functions * `undefined` handling * object literals {a: 1, "b": expr} * more tests for weird JS comparisons: see ytdl-org#31173 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boilerplate: mixed code, improvement/bug fix
## Please follow the guide belowx
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
This PR continues the upgrade of the mini JS interpreter and also addresses new syntax served in player c81bbb4a served by YouTube.
The PR adds support for:
undefined
handling