-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[motherless] Fixed the broken uploader_id in the extractor. #31243
Conversation
Apparently the motherless.com has the "thumb-member-username" item replaced by "media-meta-member", so updating the extractor accordingly.
* https://github.com/ytdl-org/youtube-dl: [netease] Get netease music download url through player api (ytdl-org#31235) [Common:JWPlayer] Fix x1000 scaling error [utils] Sanitize look-alike Unicode glyphs in non-ID filename fields when --restrict-filenames [JSInterp] Improve separation logic [ZDF] Overhaul ZDF extractors * pull some yt-dlp changes into ZDFBaseIE._extract_format() * add test cases from yt-dlp to ZDFIE * fix crash in ZDFIE._extract_mobile() when object had no `formitaeten` * improve title extraction in ZDFChannelIE (remove trailing station ident) * avoid extracting non-video playlist items (fixes ytdl-org#31149) [test] Implement string "lambda x: condition(x)" as an expected value [motherless] Fixed the broken uploader_id in the extractor (ytdl-org#31243)
Never mean to be 31273. Must be a typo :bump |
I suspect JS autofilling ... Anyhow this extractor now has no open issues! |
Thank you both 😄 ; for correctness' sake, could either one of you remove the reference/link to (wrong) |
done. |
Thanks 😄 , but you can leave |
done again. |
…31243) * Fixed the broken uploader_id in the extractor. * Make uploader_id RE looser * Fix uploader_id in test Motherless_3 * Fix group pagination * # coding: utf-8 Co-authored-by: Andy Xuming <xuminic@gmail.com> Co-authored-by: dirkf <fieldhouse@gmx.net>
Apparently the motherless.com has the "thumb-member-username" item replaced by "media-meta-member", so updating the extractor accordingly.
Please follow the guide below
x
into all the boxes [ ] relevant to your pull request (like that [x])Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
What is the purpose of your pull request?
Description of your pull request and other information
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible. Fix #29626 and #31128.
Current extractor of motherless.com is unable to extract the uploader_id. For example:
The reason has been found the website had changed the "thumb-member-username" by "media-meta-member". So change the extractor accordingly:
Testing like this: