Fix: Go static checks are failing with go version format mismatch with latest staticcheck package #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyanshi-yb
changed the title
sanyamsinghal
approved these changes
Aug 14, 2024
| @@ -36,5 +36,5 @@ jobs: | |||
| - name: Run staticcheck | |||
| run: | | |||
| cd yb-voyager | |||
| go install honnef.co/go/tools/cmd/staticcheck@latest | |||
| go install honnef.co/go/tools/cmd/staticcheck@2023.1.7 | |||
There was a problem hiding this comment.
just to confirm: this is second latest release?
There was a problem hiding this comment.
Right, excluding RC release of latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go
Run staticcheckis failing with latestgo/tools/cmd/staticcheckpackage with an error -which seems to be not working with current go version we use, so restricting the static check package to use the last release before the latest i.e. 2023.1.7