Skip to content

Commit

Permalink
[PLAT-14515][UI] Clicking preview doesn't show the correct info and c…
Browse files Browse the repository at this point in the history
…lears up the data provided while setting up the ysql_ident or ysql_hba multiline flags.- [PLAT-14514] [PLAT-14513]

Summary:
GFlags component uses onBlur event on YBInput to build the GFlags. But, we made a fix in this [[ https://phorge.dev.yugabyte.com/D35478 | diff ]] to fire the onBlur event only if the input contains a space(trimming). So, adding Gflags fails.

Fix:
move the onBlur events a level above from YBinput to the parent div.

Test Plan: Tested manually by adding GFlags

Reviewers: lsangappa, jmak, rmadhavan

Reviewed By: lsangappa, rmadhavan

Subscribers: yugaware

Differential Revision: https://phorge.dev.yugabyte.com/D36202
  • Loading branch information
haikarthikssk committed Jun 27, 2024
1 parent 70a87f9 commit 26fbfe0
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@ export const EditGFlagsConf: FC<EditGFlagConfProps> = ({
ref={provided.innerRef}
{...provided.draggableProps}
{...provided.dragHandleProps}
onBlur={() => buildGFlagConf()}
>
<Box display="flex" flexDirection="column">
<Box display="flex" flexDirection="row">
Expand All @@ -391,7 +392,6 @@ export const EditGFlagsConf: FC<EditGFlagConfProps> = ({
: CONST_VALUES.EMPTY_STRING
}
onChange={(e: any) => handleChange(e.target.value, index)}
onBlur={() => buildGFlagConf()}
error={GFlagRows[index]?.error}
helperText={t(GFlagRows[index].errorMessageKey!)}
inputProps={{
Expand Down

0 comments on commit 26fbfe0

Please sign in to comment.