Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[YSQL] Integrate YSQL follower reads feature with READ COMMITTED isolation level #11641

Closed
pkj415 opened this issue Mar 3, 2022 · 2 comments
Closed

[YSQL] Integrate YSQL follower reads feature with READ COMMITTED isolation level #11641

pkj415 opened this issue Mar 3, 2022 · 2 comments
Assignees
@pkj415 @amitanandaiyer
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue

Comments

@pkj415
Copy link
Contributor

pkj415 commented Mar 3, 2022 •
edited by yugabyte-ci
Loading

Jira Link: DB-903

Description

This will involve picking (now - yb_follower_read_staleness_ms) as the read point for each query.
@pkj415 pkj415 added the area/ysql Yugabyte SQL (YSQL) label Mar 3, 2022
@pkj415 pkj415 self-assigned this Mar 3, 2022
@pkj415 pkj415 mentioned this issue Mar 3, 2022
Open
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 8, 2022
@amitanandaiyer amitanandaiyer mentioned this issue Jun 15, 2022
Closed
@amitanandaiyer amitanandaiyer self-assigned this Jun 16, 2022
amitanandaiyer added a commit that referenced this issue Jun 23, 2022
@amitanandaiyer
[#11641]: Docdb : Make Follower reads work with Read Committed isolat…
148d251 
…ion.

Summary:
Track the waits for safe-time in the traces (at tracing level 3)

Fix: Call UpdateReadTimeForFollowerReads correctly after each stmt in ReadCommitted mode

SetReadPoint must use read_point() to set the transactional read point

Test Plan:
ybd --java-test TestPgFollowerReads#testFollowerReadsOnReadCommitted

Reviewers: pjain

Reviewed By: pjain

Subscribers: bogdan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D17743
@jameshartig
Copy link
Contributor

We just ran into this. I assume it'll be ported back to 2.12? I also know that 2.14 is coming up so we're also considering just turning off read committed for now until 2.14.

@amitanandaiyer
Copy link
Contributor

@jameshartig I am planning on porting this to 2.12.

in the meanwhile, as a workaround you could explicitly set queries that use follower reads to use Read_repeatable.

(you can still use Read Committed for non-follower read queries/updates)

amitanandaiyer added a commit that referenced this issue Jun 27, 2022
@amitanandaiyer
[Backport 2.14] [#11641]: Docdb : Make Follower reads work with Read …
21780fb 
…Committed isolation.

Summary:
Track the waits for safe-time in the traces (at tracing level 3)

Fix: Call UpdateReadTimeForFollowerReads correctly after each stmt in ReadCommitted mode

SetReadPoint must use read_point() to set the transactional read point

Original Revision: https://phabricator.dev.yugabyte.com/D17743
Original Commit: 148d251

Test Plan: ybd --java-test TestPgFollowerReads#testFollowerReadsOnReadCommitted

Reviewers: pjain

Reviewed By: pjain

Subscribers: bogdan, ybase

Differential Revision: https://phabricator.dev.yugabyte.com/D17882
amitanandaiyer added a commit that referenced this issue Jul 13, 2022
@amitanandaiyer
[Backport 2.12] [#11641]: Docdb : Make Follower reads work with Read …
ee06566 
…Committed isolation.

Summary:
Track the waits for safe-time in the traces (at tracing level 3)

Fix: Call UpdateReadTimeForFollowerReads correctly after each stmt in ReadCommitted mode

SetReadPoint must use read_point() to set the transactional read point

Original Revision: https://phabricator.dev.yugabyte.com/D17743
Original Commit: 148d251

Test Plan: ybd --java-test TestPgFollowerReads#testFollowerReadsOnReadCommitted

Reviewers: pjain

Reviewed By: pjain

Subscribers: ybase, bogdan

Differential Revision: https://phabricator.dev.yugabyte.com/D17880
@pkj415 pkj415 mentioned this issue Aug 9, 2022
Open
@pkj415 pkj415 closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkj415 pkj415

@amitanandaiyer amitanandaiyer

Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug priority/medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jameshartig @pkj415 @yugabyte-ci @amitanandaiyer