Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flaky test] org.yb.pgsql.TestPgRegressTypesUDT.testPgRegressTypesUDT #11717

Closed
bmatican opened this issue Mar 10, 2022 · 2 comments
Closed

[flaky test] org.yb.pgsql.TestPgRegressTypesUDT.testPgRegressTypesUDT #11717

bmatican opened this issue Mar 10, 2022 · 2 comments
Assignees
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug kind/failing-test Tests and testing infra priority/medium Medium priority issue

Comments

@bmatican
Copy link
Contributor

bmatican commented Mar 10, 2022

@bmatican bmatican added the area/ysql Yugabyte SQL (YSQL) label Mar 10, 2022
@yugabyte-ci yugabyte-ci added kind/bug This issue is a bug priority/medium Medium priority issue labels Jun 8, 2022
@mbautin
Copy link
Contributor

mbautin commented Jun 26, 2022

Currently I see this error in the log:

***************
*** 591,599 ****
  INSERT INTO cstring_table (t)
      VALUES ('thisiscstring');
  SELECT * FROM cstring_table;
!        t
! ---------------
!  thisiscstring
  (1 row)

  DROP TABLE cstring_table;
--- 591,599 ----
  INSERT INTO cstring_table (t)
      VALUES ('thisiscstring');
  SELECT * FROM cstring_table;
!               t
! ------------------------------
!  thisiscstring\x10\x10@l\\x13
  (1 row)

  DROP TABLE cstring_table;

@mbautin
Copy link
Contributor

mbautin commented Jun 26, 2022

The random bytes in the incorrect result seem to be changing:

***************
*** 591,599 ****
  INSERT INTO cstring_table (t)
      VALUES ('thisiscstring');
  SELECT * FROM cstring_table;
!        t
! ---------------
!  thisiscstring
  (1 row)

  DROP TABLE cstring_table;
--- 591,599 ----
  INSERT INTO cstring_table (t)
      VALUES ('thisiscstring');
  SELECT * FROM cstring_table;
!             t
! --------------------------
!  thisiscstring\x01 0|\x03
  (1 row)

  DROP TABLE cstring_table;

@mbautin mbautin assigned m-iancu and unassigned spolitov Jun 27, 2022
@m-iancu m-iancu assigned ramsrivatsa and unassigned m-iancu Jun 28, 2022
d-uspenskiy added a commit that referenced this issue Jul 13, 2022
Summary: In context of the bc2b661 / D6900 the `YBCNullTermByRefTypeEntity` object was introduced to convert null-terminated string into DocDB representation. DocDB representation was selected as `YB_YQL_DATA_TYPE_BINARY `. And this type doesn't hold termination `\0` character. It has to be added at the conversion step from DocDB to YSQL representation.

Test Plan:
Jenkins
Run existed test
```
./yb_build.sh --java-test 'org.yb.pgsql.TestPgRegressTypesUDT#testPgRegressTypesUDT' -n 10
```

Reviewers: neil, jason, rskannan, mbautin

Reviewed By: rskannan, mbautin

Subscribers: kannan, mbautin, yql

Differential Revision: https://phabricator.dev.yugabyte.com/D18275
@d-uspenskiy d-uspenskiy moved this to Done in YQL-beta Jul 13, 2022
@yugabyte-ci yugabyte-ci added the kind/failing-test Tests and testing infra label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ysql Yugabyte SQL (YSQL) kind/bug This issue is a bug kind/failing-test Tests and testing infra priority/medium Medium priority issue
Projects
Status: Done
Development

No branches or pull requests

7 participants